[French Translation] First step review#417
Closed
ldmpub wants to merge 4 commits intoRazeeman:devfrom
Closed
Conversation
Stop review at ligne 135 / <!-- Change record -->
Owner
|
Hello! Thank you very much for the help. Does "Stop review at ligne 135" mean that the PR is not ready yet? |
Contributor
Author
|
Your're welcomed, This PR is ready to be merged. The review will take me a long long time ... further PR to come (but not before 1 week or 2). |
Razeeman
reviewed
Jan 4, 2026
Owner
|
Great work! Left few comments for discussion. |
Contributor
Author
|
Thanks a lot for your detailed review of this Merge Request 🙏. Several general remarks:
|
Contributor
Author
|
Hi, Sorry, I'm not to familiar with fork and branches within GitHub => I performed deletion of my old "patch-1" branch and it has automatically closed this PR ... Despite above discussion topics are still accurate, all my translation changes are to be seen here in a new PR => #421 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop major review at line 135
/ <!-- Change record -->